[patch] viafb: NULL dereference on allocation failure in query_edid()
flat view
STALE5351d
From: Dan Carpenter <hidden>
Date: 2012-02-17 06:45:01
Also in:
kernel-janitors
Subsystem:
framebuffer layer, the rest · Maintainers:
Helge Deller, Linus Torvalds
We should handle the allocation here, if only to keep the static checkers happy. Signed-off-by: Dan Carpenter <redacted>
diff --git a/drivers/video/via/via_aux_edid.c b/drivers/video/via/via_aux_edid.c
index 03f7a41..754d450 100644
--- a/drivers/video/via/via_aux_edid.c
+++ b/drivers/video/via/via_aux_edid.c@@ -36,10 +36,13 @@ static void query_edid(struct via_aux_drv *drv) unsigned char edid[EDID_LENGTH]; bool valid = false; - if (spec) + if (spec) { fb_destroy_modedb(spec->modedb); - else + } else { spec = kmalloc(sizeof(*spec), GFP_KERNEL); + if (!spec) + return; + } spec->version = spec->revision = 0; if (via_aux_read(drv, 0x00, edid, EDID_LENGTH)) {