On Thu, 19 Jan 2012 20:08:07 +0530
Archit [off-list ref] wrote:
On Thursday 19 January 2012 10:58 AM, Donghwa Lee wrote:
quoted
Samsung S5PC210 and EXYNOS SoC platform has MIPI-DSI controller and MIPI-DSI
based LCD Panel could be used with it. This patch supports MIPI-DSI driver
based Samsung SoC chip.
LCD panel driver based MIPI-DSI should be registered to MIPI-DSI driver at
machine code and LCD panel driver specific function registered to mipi_dsim_ddi
structure at lcd panel init function called system init.
In the MIPI-DSI driver, find lcd panel driver by using registered
lcd panel name, and then initialize lcd panel driver.
Changes since v6:
- remove obscure compile problems.
- remove useless codes.
- modify return errno codes properly
One more comment about 'mipi_dsim.h', it would be better to put it in
include/video and not 'include/linux'.
From: Donghwa Lee <hidden> Date: 2012-01-25 00:14:58
On Sat, 21 Jan 2012 08:51, Andrew Morton wrote:
On Thu, 19 Jan 2012 20:08:07 +0530
Archit [off-list ref] wrote:
quoted
On Thursday 19 January 2012 10:58 AM, Donghwa Lee wrote:
quoted
Samsung S5PC210 and EXYNOS SoC platform has MIPI-DSI controller and MIPI-DSI
based LCD Panel could be used with it. This patch supports MIPI-DSI driver
based Samsung SoC chip.
LCD panel driver based MIPI-DSI should be registered to MIPI-DSI driver at
machine code and LCD panel driver specific function registered to mipi_dsim_ddi
structure at lcd panel init function called system init.
In the MIPI-DSI driver, find lcd panel driver by using registered
lcd panel name, and then initialize lcd panel driver.
Changes since v6:
- remove obscure compile problems.
- remove useless codes.
- modify return errno codes properly
One more comment about 'mipi_dsim.h', it would be better to put it in
include/video and not 'include/linux'.
or we could put it in drivers/video/. It all depends on which other
drivers we expect will need access to this header.
No, mipi_dsim.h file includes global interface data, callback function called by machine
file, platform data for mipi-dsi driver and so on. So I think it would be better to put
in 'include/video' or 'include/linux'.
Of course it is much better to change name to 's5p_mipi_dsim.h'
Thank you,
Donghwa Lee
From: Tomi Valkeinen <hidden> Date: 2012-01-26 15:45:57
Hi,
On Wed, 2012-01-25 at 09:14 +0900, Donghwa Lee wrote:
On Sat, 21 Jan 2012 08:51, Andrew Morton wrote:
quoted
On Thu, 19 Jan 2012 20:08:07 +0530
Archit [off-list ref] wrote:
quoted
On Thursday 19 January 2012 10:58 AM, Donghwa Lee wrote:
quoted
Samsung S5PC210 and EXYNOS SoC platform has MIPI-DSI controller and MIPI-DSI
based LCD Panel could be used with it. This patch supports MIPI-DSI driver
based Samsung SoC chip.
LCD panel driver based MIPI-DSI should be registered to MIPI-DSI driver at
machine code and LCD panel driver specific function registered to mipi_dsim_ddi
structure at lcd panel init function called system init.
In the MIPI-DSI driver, find lcd panel driver by using registered
lcd panel name, and then initialize lcd panel driver.
Changes since v6:
- remove obscure compile problems.
- remove useless codes.
- modify return errno codes properly
One more comment about 'mipi_dsim.h', it would be better to put it in
include/video and not 'include/linux'.
or we could put it in drivers/video/. It all depends on which other
drivers we expect will need access to this header.
No, mipi_dsim.h file includes global interface data, callback function called by machine
file, platform data for mipi-dsi driver and so on. So I think it would be better to put
in 'include/video' or 'include/linux'.
Of course it is much better to change name to 's5p_mipi_dsim.h'
The header file looks like a platform specific header, so I agree that
it should start with s5p.
I think we should finally start working on a common DSI framework =).
Tomi
From: Donghwa Lee <hidden> Date: 2012-01-27 01:42:57
2012년 01월 27일 00:45, Tomi Valkeinen 쓴 글:
Hi,
On Wed, 2012-01-25 at 09:14 +0900, Donghwa Lee wrote:
quoted
On Sat, 21 Jan 2012 08:51, Andrew Morton wrote:
quoted
On Thu, 19 Jan 2012 20:08:07 +0530
Archit [off-list ref] wrote:
quoted
On Thursday 19 January 2012 10:58 AM, Donghwa Lee wrote:
quoted
Samsung S5PC210 and EXYNOS SoC platform has MIPI-DSI controller and MIPI-DSI
based LCD Panel could be used with it. This patch supports MIPI-DSI driver
based Samsung SoC chip.
LCD panel driver based MIPI-DSI should be registered to MIPI-DSI driver at
machine code and LCD panel driver specific function registered to mipi_dsim_ddi
structure at lcd panel init function called system init.
In the MIPI-DSI driver, find lcd panel driver by using registered
lcd panel name, and then initialize lcd panel driver.
Changes since v6:
- remove obscure compile problems.
- remove useless codes.
- modify return errno codes properly
One more comment about 'mipi_dsim.h', it would be better to put it in
include/video and not 'include/linux'.
or we could put it in drivers/video/. It all depends on which other
drivers we expect will need access to this header.
No, mipi_dsim.h file includes global interface data, callback function called by machine
file, platform data for mipi-dsi driver and so on. So I think it would be better to put
in 'include/video' or 'include/linux'.
Of course it is much better to change name to 's5p_mipi_dsim.h'
The header file looks like a platform specific header, so I agree that
it should start with s5p.
I think we should finally start working on a common DSI framework =).
Tomi
Yes, I agree with you. I will resend next version patch set changed file name
from 'mipi_dsim.h' to 's5p_mipi_dsim.h'
Thank you,
Donghwa Lee
From: Jingoo Han <hidden> Date: 2012-01-27 03:06:51
Hi, Tomi.
-----Original Message-----
From: linux-fbdev-owner@vger.kernel.org [mailto:linux-fbdev-owner@vger.kernel.org] On Behalf Of Tomi
Valkeinen
Sent: Friday, January 27, 2012 12:46 AM
To: Donghwa Lee
Cc: Andrew Morton; Archit; linux-fbdev@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Florian
Tobias Schandinat; rpurdie@linux.intel.com; inki.dae@samsung.com; kyungmin.park@samsung.com
Subject: Re: [PATCH v7 1/2] video: support MIPI-DSI controller driver
Hi,
On Wed, 2012-01-25 at 09:14 +0900, Donghwa Lee wrote:
quoted
On Sat, 21 Jan 2012 08:51, Andrew Morton wrote:
quoted
On Thu, 19 Jan 2012 20:08:07 +0530
Archit [off-list ref] wrote:
quoted
On Thursday 19 January 2012 10:58 AM, Donghwa Lee wrote:
quoted
Samsung S5PC210 and EXYNOS SoC platform has MIPI-DSI controller and MIPI-DSI
based LCD Panel could be used with it. This patch supports MIPI-DSI driver
based Samsung SoC chip.
LCD panel driver based MIPI-DSI should be registered to MIPI-DSI driver at
machine code and LCD panel driver specific function registered to mipi_dsim_ddi
structure at lcd panel init function called system init.
In the MIPI-DSI driver, find lcd panel driver by using registered
lcd panel name, and then initialize lcd panel driver.
Changes since v6:
- remove obscure compile problems.
- remove useless codes.
- modify return errno codes properly
One more comment about 'mipi_dsim.h', it would be better to put it in
include/video and not 'include/linux'.
or we could put it in drivers/video/. It all depends on which other
drivers we expect will need access to this header.
No, mipi_dsim.h file includes global interface data, callback function called by machine
file, platform data for mipi-dsi driver and so on. So I think it would be better to put
in 'include/video' or 'include/linux'.
Of course it is much better to change name to 's5p_mipi_dsim.h'
The header file looks like a platform specific header, so I agree that
it should start with s5p.
I think we should finally start working on a common DSI framework =).
I agree with you in your opinion.
The common DSI framework would be useful.
Thank you.