Re: udlfb: remove sysfs framebuffer device with USB .disconnect()

On Sat, Jan 21, 2012 at 15:32, Kay Sievers [off-list ref] wrote:

On Sat, 2012-01-21 at 14:13 +0000, Florian Tobias Schandinat wrote:

quoted

On 01/21/2012 01:57 PM, Kay Sievers wrote:

quoted

quoted

That's true. If one calls the current _unregister() *before* calling
_unlink(), the _unlink() is a NOP. But that's intentional.

I don't think you got me right. My complaint was that after your patch
do_unregister_framebuffer itself calls unlink_framebuffer _after_ it set
registered_fb[i] = NULL;
So for any framebuffer that does not call unlink_framebuffer directly the line
device_destroy(fb_class, MKDEV(FB_MAJOR, i));
will no longer be executed. Do you agree?

Yes, I absolutely agree. :)

Hey Florian,

any updates?

We like to get that into the Fedora kernel, as we promised
out-of-the-box multi-seat hotplug support, but the framebuffer events
are broken at the moment.

It would be nice if it would show up in -next somehow, and gets
testing, so I don't need to convince anybody at the Fedora kernel
side, that this will land upstream ...

Thanks,
Kay