[GIT PULL] OMAP DSS fixes for 3.3-rc

Started by Tomi Valkeinen on Jan 26, 2012 · 7 messages from 3 authors · Last reply Feb 29, 2012

open the first message on its own page

Tomi Valkeinen

Message details and related content
Open message details and related content
Hi Florian,

Here are two major fixes for OMAP DSS driver.

The first (OMAPDSS: use sync versions...) fixes problem with system
suspend, which causes omapdss power management to give WARNs and
generally malfunction on system suspend/resume.

The second (the rest of the patches) implements a workaround for HW bug,
which causes physical damage to the board if the HDMI cable is
disconnected at a "wrong" time. The actual fix is in the last patch, but
the board files needed some cleanups and a new GPIO, which is what the
smaller patches do.

The branch is based on fbdev/fbdev-next. Is that ok?

 Tomi


The following changes since commit f787f32e67e00b072f46b2ae3c454d2c0a1fcdb7:

  module_param: make bool parameters really bool (drivers/video/i810) (2012-01-12 23:28:59 +0000)

are available in the git repository at:
  git://gitorious.org/linux-omap-dss2/linux.git for-3.3-rc

Tomi Valkeinen (7):
      OMAPDSS: use sync versions of pm_runtime_put
      OMAP: 4430SDP/Panda: use gpio_free_array to free HDMI gpios
      OMAP: 4430SDP/Panda: rename HPD GPIO to CT_CP_HPD
      OMAPDSS: remove wrong HDMI HPD muxing
      OMAP: 4430SDP/Panda: setup HDMI GPIO muxes
      OMAP: 4430SDP/Panda: add HDMI HPD gpio
      OMAPDSS: HDMI: PHY burnout fix

 arch/arm/mach-omap2/board-4430sdp.c       |   18 ++++++--
 arch/arm/mach-omap2/board-omap4panda.c    |   18 ++++++--
 arch/arm/mach-omap2/display.c             |    4 --
 drivers/video/omap2/dss/dispc.c           |    2 +-
 drivers/video/omap2/dss/dsi.c             |    2 +-

9 more lines

Florian Tobias Schandinat replied to Tomi Valkeinen

Message details and related content
Open message details and related content
Hi Tomi,

On 01/26/2012 12:07 PM, Tomi Valkeinen wrote:
Hi Florian,

Here are two major fixes for OMAP DSS driver.

The first (OMAPDSS: use sync versions...) fixes problem with system
suspend, which causes omapdss power management to give WARNs and
generally malfunction on system suspend/resume.

The second (the rest of the patches) implements a workaround for HW bug,
which causes physical damage to the board if the HDMI cable is
disconnected at a "wrong" time. The actual fix is in the last patch, but
the board files needed some cleanups and a new GPIO, which is what the
smaller patches do.

The branch is based on fbdev/fbdev-next. Is that ok?
Yes, that worked well, as I didn't start to collect 3.4 material there. Merged.


Thanks,

Florian Tobias Schandinat

 Tomi


The following changes since commit f787f32e67e00b072f46b2ae3c454d2c0a1fcdb7:

  module_param: make bool parameters really bool (drivers/video/i810) (2012-01-12 23:28:59 +0000)

are available in the git repository at:
  git://gitorious.org/linux-omap-dss2/linux.git for-3.3-rc

Tomi Valkeinen (7):
      OMAPDSS: use sync versions of pm_runtime_put
      OMAP: 4430SDP/Panda: use gpio_free_array to free HDMI gpios
      OMAP: 4430SDP/Panda: rename HPD GPIO to CT_CP_HPD
      OMAPDSS: remove wrong HDMI HPD muxing
      OMAP: 4430SDP/Panda: setup HDMI GPIO muxes
      OMAP: 4430SDP/Panda: add HDMI HPD gpio
      OMAPDSS: HDMI: PHY burnout fix

 arch/arm/mach-omap2/board-4430sdp.c       |   18 ++++++--
 arch/arm/mach-omap2/board-omap4panda.c    |   18 ++++++--
 arch/arm/mach-omap2/display.c             |    4 --
 drivers/video/omap2/dss/dispc.c           |    2 +-
 drivers/video/omap2/dss/dsi.c             |    2 +-
 drivers/video/omap2/dss/dss.c             |    2 +-
 drivers/video/omap2/dss/hdmi.c            |    5 ++-
 drivers/video/omap2/dss/rfbi.c            |    2 +-
 drivers/video/omap2/dss/ti_hdmi.h         |    4 ++
 drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c |   68 +++++++++++++++++++++++++++--
 drivers/video/omap2/dss/venc.c            |    2 +-
 include/video/omapdss.h                   |    5 ++
 12 files changed, 110 insertions(+), 22 deletions(-)





  

    

      
      Tomi Valkeinen      replied to Tomi Valkeinen      
      
    

  

  

    Message details and related content
    
Open message details and related content

  

  
Hi Florian,

Two fixes for OMAP DSS for 3.3:

First one gets the HDMI output working again. Managing the clocks for
OMAP4 is not very simple, and this patch circumvents the problems we
have in the clock framework. It's a clean but rather hacky fix, but it
shouldn't cause any side-effects. The issue will hopefully be fixed
properly with DT when we'll get proper parent-child hierarchy for DSS HW
submodules.

The second one is a simple fix for HDMI hotplug detection, which I
missed when I wrote the HDMI PHY fix
(c49d005b6cc8491fad5b24f82805be2d6bcbd3dd).

 Tomi

The following changes since commit d65b4e98d7ea3038b767b70fe8be959b2913f16d:

  Linux 3.3-rc3 (2012-02-08 19:21:53 -0800)

are available in the git repository at:
  git://gitorious.org/linux-omap-dss2/linux.git for-3.3-rc

Archit Taneja (1):
      OMAPDSS: HACK: Ensure DSS clock domain gets out of idle when HDMI is enabled

Rob Clark (1):
      OMAPDSS: HDMI: hot plug detect fix

 drivers/video/omap2/dss/hdmi.c            |   24 +++++++++++++++++++++++-
 drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c |    9 +--------
 2 files changed, 24 insertions(+), 9 deletions(-)






  

    

      
      Florian Tobias Schandinat      replied to Tomi Valkeinen      
      
    

  

  

    Message details and related content
    
Open message details and related content

  

  
On 02/23/2012 09:22 AM, Tomi Valkeinen wrote:
Hi Florian,

Two fixes for OMAP DSS for 3.3:

First one gets the HDMI output working again. Managing the clocks for
OMAP4 is not very simple, and this patch circumvents the problems we
have in the clock framework. It's a clean but rather hacky fix, but it
shouldn't cause any side-effects. The issue will hopefully be fixed
properly with DT when we'll get proper parent-child hierarchy for DSS HW
submodules.

The second one is a simple fix for HDMI hotplug detection, which I
missed when I wrote the HDMI PHY fix
(c49d005b6cc8491fad5b24f82805be2d6bcbd3dd).
Merged. You would add
Cc: <redacted>
to patches if appropriate?


Thanks,

Florian Tobias Schandinat

 Tomi

The following changes since commit d65b4e98d7ea3038b767b70fe8be959b2913f16d:

  Linux 3.3-rc3 (2012-02-08 19:21:53 -0800)

are available in the git repository at:
  git://gitorious.org/linux-omap-dss2/linux.git for-3.3-rc

Archit Taneja (1):
      OMAPDSS: HACK: Ensure DSS clock domain gets out of idle when HDMI is enabled

Rob Clark (1):
      OMAPDSS: HDMI: hot plug detect fix

 drivers/video/omap2/dss/hdmi.c            |   24 +++++++++++++++++++++++-
 drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c |    9 +--------
 2 files changed, 24 insertions(+), 9 deletions(-)





  

    

      
      Tomi Valkeinen      replied to Florian Tobias Schandinat      
      
    

  

  

    Message details and related content
    
Open message details and related content

  

  
On Tue, 2012-02-28 at 16:03 +0000, Florian Tobias Schandinat wrote:
On 02/23/2012 09:22 AM, Tomi Valkeinen wrote:
quoted
Hi Florian,

Two fixes for OMAP DSS for 3.3:

First one gets the HDMI output working again. Managing the clocks for
OMAP4 is not very simple, and this patch circumvents the problems we
have in the clock framework. It's a clean but rather hacky fix, but it
shouldn't cause any side-effects. The issue will hopefully be fixed
properly with DT when we'll get proper parent-child hierarchy for DSS HW
submodules.

The second one is a simple fix for HDMI hotplug detection, which I
missed when I wrote the HDMI PHY fix
(c49d005b6cc8491fad5b24f82805be2d6bcbd3dd).
Merged. You would add
Cc: <redacted>
to patches if appropriate?
Thanks. Yes, I have sent a separate mail to stable list, as the patches
needed some tuning to apply.

 Tomi






  

    

      
      Jingoo Han      replied to Florian Tobias Schandinat      
      
    

  

  

    Message details and related content
    
Open message details and related content

  

  
Hi.
-----Original Message-----
From: <redacted> [mailto:<redacted>] On Behalf Of Florian
Tobias Schandinat
Sent: Wednesday, February 29, 2012 1:03 AM
To: Tomi Valkeinen
Cc: <redacted>; linux-omap mailing list
Subject: Re: [GIT PULL] OMAP DSS fixes for 3.3-rc

On 02/23/2012 09:22 AM, Tomi Valkeinen wrote:
quoted
Hi Florian,

Two fixes for OMAP DSS for 3.3:

First one gets the HDMI output working again. Managing the clocks for
OMAP4 is not very simple, and this patch circumvents the problems we
have in the clock framework. It's a clean but rather hacky fix, but it
shouldn't cause any side-effects. The issue will hopefully be fixed
properly with DT when we'll get proper parent-child hierarchy for DSS HW
submodules.

The second one is a simple fix for HDMI hotplug detection, which I
missed when I wrote the HDMI PHY fix
(c49d005b6cc8491fad5b24f82805be2d6bcbd3dd).
Merged. You would add
Cc: <redacted>
to patches if appropriate?
I agree on Florian's opinion.
It would be good to add this patch to stable kernel. :)


Thanks,

Florian Tobias Schandinat

quoted
 Tomi

The following changes since commit d65b4e98d7ea3038b767b70fe8be959b2913f16d:

  Linux 3.3-rc3 (2012-02-08 19:21:53 -0800)

are available in the git repository at:
  git://gitorious.org/linux-omap-dss2/linux.git for-3.3-rc

Archit Taneja (1):
      OMAPDSS: HACK: Ensure DSS clock domain gets out of idle when HDMI is enabled

Rob Clark (1):
      OMAPDSS: HDMI: hot plug detect fix

 drivers/video/omap2/dss/hdmi.c            |   24 +++++++++++++++++++++++-
 drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c |    9 +--------
 2 files changed, 24 insertions(+), 9 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html





  

    

      
      Jingoo Han      replied to Tomi Valkeinen      
      
    

  

  

    Message details and related content
    
Open message details and related content

  

  
-----Original Message-----
From: <redacted> [mailto:<redacted>] On Behalf Of Tomi
Valkeinen
Sent: Wednesday, February 29, 2012 1:08 AM
To: Florian Tobias Schandinat
Cc: <redacted>; linux-omap mailing list
Subject: Re: [GIT PULL] OMAP DSS fixes for 3.3-rc

On Tue, 2012-02-28 at 16:03 +0000, Florian Tobias Schandinat wrote:
quoted
On 02/23/2012 09:22 AM, Tomi Valkeinen wrote:
quoted
Hi Florian,

Two fixes for OMAP DSS for 3.3:

First one gets the HDMI output working again. Managing the clocks for
OMAP4 is not very simple, and this patch circumvents the problems we
have in the clock framework. It's a clean but rather hacky fix, but it
shouldn't cause any side-effects. The issue will hopefully be fixed
properly with DT when we'll get proper parent-child hierarchy for DSS HW
submodules.

The second one is a simple fix for HDMI hotplug detection, which I
missed when I wrote the HDMI PHY fix
(c49d005b6cc8491fad5b24f82805be2d6bcbd3dd).
Merged. You would add
Cc: <redacted>
to patches if appropriate?
Thanks. Yes, I have sent a separate mail to stable list, as the patches
needed some tuning to apply.
Tomi, sorry.
You have already sent a mail to stable@vger.kernel.org.
Good luck.

Best regards,
Jingoo Han
 Tomi










    
  

  
    

      

        Keyboard shortcuts
      

      

        
          
hback out one level

          
jnext message in thread / next series-diff position

          
kprevious message in thread / previous series-diff position

          
ldrill in

          
Escclose help / fold thread tree

          
?toggle this help