Re: [patch v2] intelfb: remove some dead code

From
Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Date
2012-01-30 05:25:04
Also in
kernel-janitors
Reply to
Dan Carpenter, 2012-01-27
On 01/27/2012 12:58 PM, Dan Carpenter wrote:
The goto on the line before means the return is unreachable.  The goto
also returns -ENODEV so no changes are needed there.

Signed-off-by: Dan Carpenter <redacted>
Applied.


Thanks,

Florian Tobias Schandinat
quoted hunk ↗ jump to hunk
---
v2: fixed a typo in the commit message
diff --git a/drivers/video/intelfb/intelfbdrv.c b/drivers/video/intelfb/intelfbdrv.c
index c6afa33..02fd226 100644
--- a/drivers/video/intelfb/intelfbdrv.c
+++ b/drivers/video/intelfb/intelfbdrv.c
@@ -529,7 +529,6 @@ static int __devinit intelfb_pci_register(struct pci_dev *pdev,
 	if (fb_alloc_cmap(&info->cmap, 256, 1) < 0) {
 		ERR_MSG("Could not allocate cmap for intelfb_info.\n");
 		goto err_out_cmap;
-		return -ENODEV;
 	}
 
 	dinfo = info->par;
  
Thread (2 messages) 2 messages, 2 authors, last reply 2012-01-30
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help