Re: [PATCH 24/57] fbdev: sh_mobile_lcdc: Return display connection state in display_on

From
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date
2011-12-19 00:21:17
Also in
linux-sh
Reply to
Laurent Pinchart, 2011-12-13
Hi Guennadi,

On Thursday 15 December 2011 18:11:03 Guennadi Liakhovetski wrote:
On Tue, 13 Dec 2011, Laurent Pinchart wrote:
quoted
Return true if the display is connected and false otherwise. Set the fb
info state to FBINFO_STATE_SUSPENDED in the sh_mobile_lcdc driver when
the display is not connected.
Hmm... I'm not sure I like functions, that return either a negative error,
or _several_ non-negative success values. How about returning -ENODEV?
That would be returning a negative error on success. Is that better ? :-)


-- 
Regards,

Laurent Pinchart
Thread (3 messages) 3 messages, 2 authors, last reply 2011-12-19
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help