RE: [PATCH] video: ep93xx-fb: add missing include of linux/module.h
flat view
From: H Hartley Sweeten <hidden>
Date: 2011-08-22 16:36:23
Also in:
lkml
On Sunday, August 21, 2011 7:39 AM, Axel Lin wrote:
quoted hunk ↗ jump to hunk
ep93xx-fb.c uses interfaces from linux/module.h, so it should include that file. This patch fixes below build errors. CC drivers/video/ep93xx-fb.o drivers/video/ep93xx-fb.c:120: error: expected ')' before 'int' drivers/video/ep93xx-fb.c:122: error: expected ')' before string constant drivers/video/ep93xx-fb.c:409: error: 'THIS_MODULE' undeclared here (not in a function) drivers/video/ep93xx-fb.c:645: error: expected declaration specifiers or '...' before string constant drivers/video/ep93xx-fb.c:645: warning: data definition has no type or storage class drivers/video/ep93xx-fb.c:645: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION' drivers/video/ep93xx-fb.c:645: warning: function declaration isn't a prototype drivers/video/ep93xx-fb.c:646: error: expected declaration specifiers or '...' before string constant drivers/video/ep93xx-fb.c:646: warning: data definition has no type or storage class drivers/video/ep93xx-fb.c:646: warning: type defaults to 'int' in declaration of 'MODULE_ALIAS' drivers/video/ep93xx-fb.c:646: warning: function declaration isn't a prototype drivers/video/ep93xx-fb.c:647: error: expected declaration specifiers or '...' before string constant drivers/video/ep93xx-fb.c:647: warning: data definition has no type or storage class drivers/video/ep93xx-fb.c:647: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR' drivers/video/ep93xx-fb.c:647: warning: function declaration isn't a prototype drivers/video/ep93xx-fb.c:649: error: expected declaration specifiers or '...' before string constant drivers/video/ep93xx-fb.c:649: warning: data definition has no type or storage class drivers/video/ep93xx-fb.c:649: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE' drivers/video/ep93xx-fb.c:649: warning: function declaration isn't a prototype make[2]: *** [drivers/video/ep93xx-fb.o] Error 1 make[1]: *** [drivers/video] Error 2 make: *** [drivers] Error 2 Signed-off-by: Axel Lin <redacted> --- drivers/video/ep93xx-fb.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)diff --git a/drivers/video/ep93xx-fb.c b/drivers/video/ep93xx-fb.c index 40e5f17..8133a9d 100644 --- a/drivers/video/ep93xx-fb.c +++ b/drivers/video/ep93xx-fb.c@@ -17,6 +17,7 @@ * */ +#include <linux/module.h> #include <linux/platform_device.h> #include <linux/dma-mapping.h> #include <linux/slab.h>
Same issue as the backlight driver...
Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com>
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ¥Šwÿº{.nÇ+‰·¥Š{±ıöİzÿâ�Ø^n‡r¡ö¦zË�ëh™¨èÚ&£ûàz¿äz¹Ş—ú+€Ê+zf£¢·hšˆ§~††Ûiÿÿï�êÿ‘êçz_è®æj:+v‰¨ş)ߣøm