Thread (3 messages) 3 messages, 3 authors, 2011-07-13

Re: [PATCH] drivers/video/udlfb bind framebuffer to interface.

From: JinGoo Han <hidden>
Date: 2011-07-11 04:26:14

Hi, Bernie Thompson.
-----Original Message-----
From: linux-fbdev-owner@vger.kernel.org [mailto:linux-fbdev-
owner@vger.kernel.org] On Behalf Of bernie@plugable.com
Sent: Wednesday, July 06, 2011 9:04 AM
To: linux-fbdev@vger.kernel.org
Cc: lethal@linux-sh.org; Kay Sievers; Bernie Thompson
Subject: [PATCH] drivers/video/udlfb bind framebuffer to interface.

From: Kay Sievers <redacted>

Udlfb has been binding the framebuffer device to its parent, which
isn't correct and causes confusion with operations like udev remove.

Coming plug and play multiseat support is dependent on this fix.

Signed-off-by: Bernie Thompson <bernie@plugable.com>
This patch author seems to be Kay Sievers [off-list ref].
Should you add Signed-off-by: Kay Sievers [off-list ref] ?
quoted hunk ↗ jump to hunk
---
 drivers/video/udlfb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/udlfb.c b/drivers/video/udlfb.c
index 816a4fd..c6584c9 100644
--- a/drivers/video/udlfb.c
+++ b/drivers/video/udlfb.c
@@ -1549,7 +1549,7 @@ static int dlfb_usb_probe(struct usb_interface
*interface,
 	/* We don't register a new USB class. Our client interface is fbdev
*/

 	/* allocates framebuffer driver structure, not framebuffer memory
*/
-	info = framebuffer_alloc(0, &usbdev->dev);
+	info = framebuffer_alloc(0, &interface->dev);
 	if (!info) {
 		retval = -ENOMEM;
 		pr_err("framebuffer_alloc failed\n");
--
1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ¥Šwÿº{.nÇ+‰·¥Š{±ıöİzÿâ�Ø^n‡r¡ö¦zË�ëh™¨è­Ú&£ûàz¿äz¹Ş—ú+€Ê+zf£¢·hšˆ§~†­†Ûiÿÿï�êÿ‘êçz_è®æj:+v‰¨ş)ߣøm
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help