Hi everybody,
When trying to understand the sh_mobile_lcdc driver, I found it hard to read
statements that include hardcoded register values. I thus wrote a patch that
replace them with macros, making the code more readable.
While doing so, I found two potential issues in the driver. See patches 2 and
3 for detailed explanations and fixes.
Laurent Pinchart (3):
fbdev: sh_mobile_lcdc: Replace hardcoded register values with macros
fbdev: sh_mobile_lcdc: Don't acknowlege interrupts unintentionally
fbdev: sh_mobile_lcdc: Compute clock pattern using divider
denominator
drivers/video/sh_mobile_lcdcfb.c | 232 +++++++++++++++++---------------------
include/video/sh_mobile_lcdc.h | 135 +++++++++++++++++++---
2 files changed, 222 insertions(+), 145 deletions(-)
--
Best regards,
Laurent Pinchart
Hi Florian,
On Friday 15 July 2011 23:52:30 Laurent Pinchart wrote:
Hi everybody,
When trying to understand the sh_mobile_lcdc driver, I found it hard to
read statements that include hardcoded register values. I thus wrote a
patch that replace them with macros, making the code more readable.
While doing so, I found two potential issues in the driver. See patches 2
and 3 for detailed explanations and fixes.
Laurent Pinchart (3):
fbdev: sh_mobile_lcdc: Replace hardcoded register values with macros
fbdev: sh_mobile_lcdc: Don't acknowlege interrupts unintentionally
fbdev: sh_mobile_lcdc: Compute clock pattern using divider
denominator
Could you please pick these patches for v3.2 ?
--
Regards,
Laurent Pinchart
On Tuesday 20 September 2011 21:30:15 Laurent Pinchart wrote:
Hi Florian,
On Friday 15 July 2011 23:52:30 Laurent Pinchart wrote:
quoted
Hi everybody,
When trying to understand the sh_mobile_lcdc driver, I found it hard to
read statements that include hardcoded register values. I thus wrote a
patch that replace them with macros, making the code more readable.
While doing so, I found two potential issues in the driver. See patches 2
and 3 for detailed explanations and fixes.
Laurent Pinchart (3):
fbdev: sh_mobile_lcdc: Replace hardcoded register values with macros
fbdev: sh_mobile_lcdc: Don't acknowlege interrupts unintentionally
fbdev: sh_mobile_lcdc: Compute clock pattern using divider
denominator
Could you please pick these patches for v3.2 ?
Sorry, I meant to answer the next version of this patch set. Please pick v2
instead.
--
Regards,
Laurent Pinchart