ARM: amba: Link fb device to its parent

Started by Loïc Minier on Jun 20, 2011 · 5 messages from 4 authors · Last reply Jun 26, 2011

Subsystems (2)

Maintainers (2)

STALE5619d

open the first message on its own page

  1. [PATCH] ARM: amba: Link fb device to its parent
    Related patches
  2. [PATCH] ARM: amba: Link fb device to its parent
    Related patches
  3. [PATCH] ARM: amba: Link fb device to its parent
    Related patches
  4. [PATCH] ARM: amba: Link fb device to its parent
    Related patches
Message details and related content
Some pieces of userspace like debian-installer expect to find the fb0
driver name by readlink-ing /sys/class/graphics/fb0/device/driver but
this was broken with amba-clcd as it sets up fb_info manually and missed
the .device parent pointer.

Signed-off-by: Loïc Minier <redacted>
Cc: Russell King <redacted>
Cc: Paul Mundt <redacted>
---
 drivers/video/amba-clcd.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/video/amba-clcd.c b/drivers/video/amba-clcd.c
index 5fc983c..cf03ad0 100644
--- a/drivers/video/amba-clcd.c
+++ b/drivers/video/amba-clcd.c
@@ -447,6 +447,8 @@ static int clcdfb_register(struct clcd_fb *fb)
 		goto out;
 	}
 
+	fb->fb.device		= &fb->dev->dev;
+
 	fb->fb.fix.mmio_start	= fb->dev->res.start;
 	fb->fb.fix.mmio_len	= resource_size(&fb->dev->res);
 
-- 
1.7.5.4
Message details and related content
On Mon, Jun 20, 2011 at 10:44:17PM +0200, Lo??c Minier wrote:
Some pieces of userspace like debian-installer expect to find the fb0
driver name by readlink-ing /sys/class/graphics/fb0/device/driver but
this was broken with amba-clcd as it sets up fb_info manually and missed
the .device parent pointer.

Signed-off-by: Lo??c Minier <redacted>
Cc: Russell King <redacted>
Cc: Paul Mundt <redacted>
---
 drivers/video/amba-clcd.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
While this is titled as an ARM patch it's certainly fbdev-specific. I'll
apply it barring any objections from Russell.
Message details and related content
On Fri, Jun 24, 2011 at 05:07:21PM +0900, Paul Mundt wrote:
On Mon, Jun 20, 2011 at 10:44:17PM +0200, Lo??c Minier wrote:
quoted
Some pieces of userspace like debian-installer expect to find the fb0
driver name by readlink-ing /sys/class/graphics/fb0/device/driver but
this was broken with amba-clcd as it sets up fb_info manually and missed
the .device parent pointer.

Signed-off-by: Lo??c Minier <redacted>
Cc: Russell King <redacted>
Cc: Paul Mundt <redacted>
---
 drivers/video/amba-clcd.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
While this is titled as an ARM patch it's certainly fbdev-specific. I'll
apply it barring any objections from Russell.
Acked-by: Russell King <redacted>
Message details and related content
On Fri, 24 Jun 2011, Paul Mundt wrote:
On Mon, Jun 20, 2011 at 10:44:17PM +0200, Lo??c Minier wrote:
quoted
Some pieces of userspace like debian-installer expect to find the fb0
driver name by readlink-ing /sys/class/graphics/fb0/device/driver but
this was broken with amba-clcd as it sets up fb_info manually and missed
the .device parent pointer.

Signed-off-by: Lo??c Minier <redacted>
Cc: Russell King <redacted>
Cc: Paul Mundt <redacted>
---
 drivers/video/amba-clcd.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
While this is titled as an ARM patch it's certainly fbdev-specific. I'll
apply it barring any objections from Russell.
BTW this should be "Loïc Minier" not "Lo??c Minier" The original email 
was fine with proper UTF-8 in that regard.  Maybe you should have a look 
at your MUA config so the resulting patch log going into git is not 
dammaged.


Nicolas
Message details and related content
On Fri, Jun 24, 2011 at 09:57:06AM -0400, Nicolas Pitre wrote:
On Fri, 24 Jun 2011, Paul Mundt wrote:
quoted
On Mon, Jun 20, 2011 at 10:44:17PM +0200, Lo??c Minier wrote:
quoted
Some pieces of userspace like debian-installer expect to find the fb0
driver name by readlink-ing /sys/class/graphics/fb0/device/driver but
this was broken with amba-clcd as it sets up fb_info manually and missed
the .device parent pointer.

Signed-off-by: Lo??c Minier <redacted>
Cc: Russell King <redacted>
Cc: Paul Mundt <redacted>
---
 drivers/video/amba-clcd.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
While this is titled as an ARM patch it's certainly fbdev-specific. I'll
apply it barring any objections from Russell.
BTW this should be "Lo?c Minier" not "Lo??c Minier" The original email 
was fine with proper UTF-8 in that regard.  Maybe you should have a look 
at your MUA config so the resulting patch log going into git is not 
dammaged.
My MUA ignores UTF-8 intentionally, but this has no bearing on the status
in my git tree.
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help