Re: [PATCH] [resend] video: s3c-fb: fix misleading kfree in remove function

On Thu, Jun 09, 2011 at 01:26:31PM +0900, Jingoo Han wrote:

This patch fixes misleading kfree in remove function.

On Thu, Jun 09, 2011 at 01:26:38PM +0900, Jingoo Han wrote:

This patch fixes mishandling in virtual resolution checking.
Previously, virtual resolution is changed to virtual_x and virtual_y
which mean the size for buffer allocation, when s3c_fb_check_var is
called by fb_check_var. However, it is meaningless, since virtual_x
and virtual_y are fixed and user cannot change virtual resolution.
Therefore, virtual resolution should be more than resolution
such as xres and yres.

On Thu, Jun 09, 2011 at 01:26:45PM +0900, Jingoo Han wrote:

This patch moves enabling channel for window, because there should
be enabling channel before enabling window. If the sequence is
reversed, it makes the problem in displaying images to lcd panel.

All applied, thanks.