Re: [PATCH 15/29] mx3fb: use display information in info not in var for panning

Hi Guennadi,

On Friday 10 June 2011 11:01:46 Guennadi Liakhovetski wrote:

On Thu, 26 May 2011, Laurent Pinchart wrote:

quoted

We must not use any information in the passed var besides xoffset,
yoffset and vmode as otherwise applications might abuse it. Also use the
aligned fix.line_length and not the (possible) unaligned xres_virtual.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Guennadi Liakhovetski <redacted>
---

 drivers/video/mx3fb.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/video/mx3fb.c b/drivers/video/mx3fb.c
index 7e3a490..759e244 100644
--- a/drivers/video/mx3fb.c
+++ b/drivers/video/mx3fb.c

@@ -1062,15 +1062,15 @@ static int mx3fb_pan_display(struct

fb_var_screeninfo *var,

 	y_bottom = var->yoffset;
 	
 	if (!(var->vmode & FB_VMODE_YWRAP))

-		y_bottom += var->yres;
+		y_bottom += fbi->var.yres;

 	if (y_bottom > fbi->var.yres_virtual)
 	
 		return -EINVAL;
 	
 	mutex_lock(&mx3_fbi->mutex);

-	offset = (var->yoffset * var->xres_virtual + var->xoffset) *
-		(var->bits_per_pixel / 8);
+	offset = var->yoffset * fbi->fix.line_length
+	       + var->xoffset * (var->bits_per_pixel / 8);

Didn't you mean

+	       + var->xoffset * (fbi->var.bits_per_pixel / 8);

Yes, my bad. Thank you.

With this fix:

Tested-by: Guennadi Liakhovetski <redacted>

(tested using http://git.ideasonboard.org/?pûdev-test.git;a=summary)

Thanks.

-- 
Regards,

Laurent Pinchart