Re: [TRIVIAL PATCH next 12/15] video: Convert vmalloc/memset to
From: Mel Gorman <hidden>
Date: 2011-05-30 11:40:34
Also in:
lkml, xen-devel
On Sat, May 28, 2011 at 10:36:32AM -0700, Joe Perches wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Joe Perches <joe@perches.com> --- drivers/video/arcfb.c | 5 ++--- drivers/video/broadsheetfb.c | 4 +--- drivers/video/hecubafb.c | 5 ++--- drivers/video/metronomefb.c | 4 +--- drivers/video/xen-fbfront.c | 3 +-- 5 files changed, 7 insertions(+), 14 deletions(-)diff --git a/drivers/video/arcfb.c b/drivers/video/arcfb.c index 3ec4923..86573e2 100644 --- a/drivers/video/arcfb.c +++ b/drivers/video/arcfb.c@@ -515,11 +515,10 @@ static int __devinit arcfb_probe(struct platform_device *dev) /* We need a flat backing store for the Arc's less-flat actual paged framebuffer */ - if (!(videomemory = vmalloc(videomemorysize))) + videomemory = vmalloc(videomemorysize); + if (!videomemory) return retval; - memset(videomemory, 0, videomemorysize); - info = framebuffer_alloc(sizeof(struct arcfb_par), &dev->dev); if (!info) goto err;
This is the first commit I saw and stopped reading at this point because this hunk is not using vzalloc. I imagine grep for ^+ and vmalloc throughout the series would be helpful? -- Mel Gorman SUSE Labs