Re: [PATCH] video: s3c-fb: fix checkpatch errors and warning
From: Tormod Volden <hidden>
Date: 2011-04-06 20:13:42
From: Tormod Volden <hidden>
Date: 2011-04-06 20:13:42
On Fri, Apr 01, 2011 at 04:17:27PM +0900, Jingoo Han wrote:quoted
Also, following warning is fixed by adding 'platid' variable which can reduce number of lines exceeding 80 characters. WARNING: line over 80 characters
Hi, wouldn't it be better to just break the line somewhere instead of introducing an extra variable to be used in a single place? Although the variable will probably be optimized away by the compiler, it adds unnecessary complexity (and slight confusion) to the code. Sorry for not commenting on this earlier, I just subscribed to the list. Best regards, Tormod