RE: [PATCH] unicore32 framebuffer driver fix: make videomemory kmalloc-ed and floatable

-----Original Message-----
From: Arnd Bergmann [mailto:arnd@arndb.de]
Sent: Tuesday, March 29, 2011 10:43 PM
To: Guan Xuetao
Cc: Paul Mundt; <redacted>; <redacted>
Subject: Re: [PATCH] unicore32 framebuffer driver fix: make videomemory kmalloc-ed and floatable

On Tuesday 29 March 2011, Guan Xuetao wrote:

quoted

1. make videomemory kmalloc-ed in fb-puv3.c
2. remove resource reservation for old fixed UNIGFX_MMAP & UVC_MMAP space
3. remove unused PKUNTIY_UNIGFX_MMAP_BASE, PKUNITY_UNIGFX_MMAP_SIZE,
        PKUNITY_UVC_MMAP_BASE, PKUNITY_UVC_MMAP_SIZE and KUSER_UNIGFX_BASE
4. remove unused header linux/vmalloc.h in fb-puv3.c

Signed-off-by: Guan Xuetao <redacted>

How does this work? UNIFB_MEMSIZE seems to be 4 MB, much more than the
maximum of 128 KB that kmalloc can allocate.

Shouldn't this use get_free_pages() instead of kmalloc?

	Arnd

When using SLUB allocator, if required memory size  is larger than 2*PAGE_SIZE, kmalloc_large is called,
and eventually __get_free_pages will  be called.
So,  it would be the same as __get_free_pages.