fbcon: Remove unused 'display *p' variable from fb_flashcursor()

Started by Sergey Senozhatsky on Mar 24, 2011 · 3 messages from 3 authors · Last reply Mar 29, 2011

Subsystems (3)

Maintainers (3)

STALE5709d

open the first message on its own page

Sergey Senozhatsky

Message details and related content
Open message details and related content
fbcon: Remove unused 'display *p' variable from fb_flashcursor()

Signed-of-by: Sergey Senozhatsky [off-list ref]

---

 drivers/video/console/fbcon.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
index c583934..8745637 100644
--- a/drivers/video/console/fbcon.c
+++ b/drivers/video/console/fbcon.c
@@ -370,7 +370,6 @@ static void fb_flashcursor(struct work_struct *work)
 {
 	struct fb_info *info = container_of(work, struct fb_info, queue);
 	struct fbcon_ops *ops = info->fbcon_par;
-	struct display *p;
 	struct vc_data *vc = NULL;
 	int c;
 	int mode;
@@ -386,7 +385,6 @@ static void fb_flashcursor(struct work_struct *work)
 		return;
 	}
 
-	p = &fb_display[vc->vc_num];
 	c = scr_readw((u16 *) vc->vc_pos);
 	mode = (!ops->cursor_flash || ops->cursor_state.enable) ?
 		CM_ERASE : CM_DRAW;

Jesse Barnes replied to Sergey Senozhatsky

Message details and related content
Open message details and related content
On Thu, 24 Mar 2011 22:50:52 +0200
Sergey Senozhatsky [off-list ref] wrote:
quoted hunk
fbcon: Remove unused 'display *p' variable from fb_flashcursor()

Signed-of-by: Sergey Senozhatsky [off-list ref]

---

 drivers/video/console/fbcon.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
index c583934..8745637 100644
--- a/drivers/video/console/fbcon.c
+++ b/drivers/video/console/fbcon.c
@@ -370,7 +370,6 @@ static void fb_flashcursor(struct work_struct *work)
 {
 	struct fb_info *info = container_of(work, struct fb_info, queue);
 	struct fbcon_ops *ops = info->fbcon_par;
-	struct display *p;
 	struct vc_data *vc = NULL;
 	int c;
 	int mode;
@@ -386,7 +385,6 @@ static void fb_flashcursor(struct work_struct *work)
 		return;
 	}
 
-	p = &fb_display[vc->vc_num];
 	c = scr_readw((u16 *) vc->vc_pos);
 	mode = (!ops->cursor_flash || ops->cursor_state.enable) ?
 		CM_ERASE : CM_DRAW;
Looks fine to me, is Paul the lucky owner of fbdev now?

-- 
Jesse Barnes, Intel Open Source Technology Center

Paul Mundt replied to Jesse Barnes

Message details and related content
Open message details and related content
On Mon, Mar 28, 2011 at 09:18:46AM -0700, Jesse Barnes wrote:
On Thu, 24 Mar 2011 22:50:52 +0200
Sergey Senozhatsky [off-list ref] wrote:
quoted
fbcon: Remove unused 'display *p' variable from fb_flashcursor()

Signed-of-by: Sergey Senozhatsky [off-list ref]
Looks fine to me, is Paul the lucky owner of fbdev now?
Seems so. I'll roll the patch in with the next batch of fixes.
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help