Re: [PATCH 09/20] video: msm: Split out MDP2.2 HW specific code.

On Wed, Mar 23 2011, Carl Vanderlip wrote:

On 03/23/2011 06:11 AM, Daniel Walker wrote:

quoted

On Fri, 2011-03-18 at 14:57 -0700, Carl Vanderlip wrote:

quoted

index df9d74e..d6e75c3 100644

--- a/arch/arm/mach-msm/Kconfig
+++ b/arch/arm/mach-msm/Kconfig

@@ -76,6 +76,11 @@ config HAS_MSM_DEBUG_UART_PHYS
 config  MSM_VIC
        bool
 
+config MSM_MDP22
+       bool
+       depends on ARCH_MSM7X00A
+       default y
+ 

You should remove the "default y" and this should be moved to a Kconfig
under video (shouldn't be added into mach-msm).

Daniel

What about removing the 'depends on' and 'default y' and making it be
selected by MSM7X00A?

But why should the feature be in the Kconfig for arch/arm/mach-msm when
the driver is under drivers/video/msm?  If it does indeed need
configuration, why not put a Kconfig under drivers/video/msm?

The last patch does select this, so it shouldn't need to get a default.

Does the code work if both MDP22 and MDP31 are defined?  Eventually, it
will be possible to enable multiple SOCs, so this driver will need to be
able to handle that determination at run-time.

David 

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.