Re: [PATCH 15/20] video: msm: convert printk to pr_*
From: Sergei Shtylyov <hidden>
Date: 2011-03-21 13:35:24
Also in:
linux-arm-kernel, linux-arm-msm, lkml
Hello. Carl Vanderlip wrote:
Reword debugging messages to use pr_err and pr_warning
Authors: Dima Zavin [off-list ref] Rebecca Schultz Zavin [off-list ref] Colin Cross [off-list ref]
Signed-off-by: Carl Vanderlip <redacted> --- drivers/video/msm/mdp.c | 11 ++++------- 1 files changed, 4 insertions(+), 7 deletions(-)
quoted hunk ↗ jump to hunk
diff --git a/drivers/video/msm/mdp.c b/drivers/video/msm/mdp.c index 8184ca9..b03204d 100644 --- a/drivers/video/msm/mdp.c +++ b/drivers/video/msm/mdp.c@@ -42,16 +42,13 @@ DEFINE_MUTEX(mdp_mutex); static int locked_enable_mdp_irq(struct mdp_info *mdp, uint32_t mask) { - int ret = 0; - BUG_ON(!mask); /* if the mask bits are already set return an error, this interrupt * is already enabled */ if (mdp_irq_mask & mask) { - printk(KERN_ERR "mdp irq already on already on %x %x\n", - mdp_irq_mask, mask); - ret = -1; + pr_err("mdp irq already on %x %x\n", mdp_irq_mask, mask); + return -1;
This change to *return* is not described.
WBR, Sergei