Thread (3 messages) 3 messages, 2 authors, 2011-03-02

Re: [PATCH] tmio: silence warnings introduced by mfd changes

From: Samuel Ortiz <hidden>
Date: 2011-03-02 10:35:04
Also in: linux-mmc, linux-next, lkml

Hi Andres,

On Tue, Mar 01, 2011 at 12:32:20PM -0800, Andres Salomon wrote:
On Tue, 1 Mar 2011 10:53:22 -0800
Andres Salomon [off-list ref] wrote:
quoted
On Tue, 1 Mar 2011 15:42:30 +1100
Stephen Rothwell [off-list ref] wrote:
quoted
Hi Samuel,

After merging the mfd tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:

drivers/video/tmiofb.c: In function 'tmiofb_hw_init':
drivers/video/tmiofb.c:270: warning: initialization discards
qualifiers from pointer target type drivers/video/tmiofb.c: In
function 'tmiofb_hw_mode': drivers/video/tmiofb.c:314: warning:
initialization discards qualifiers from pointer target type
drivers/video/tmiofb.c:314: warning: unused variable 'cell'
drivers/video/tmiofb.c: In function 'tmiofb_probe':
drivers/video/tmiofb.c:683: warning: initialization discards
qualifiers from pointer target type drivers/video/tmiofb.c: In
function 'tmiofb_remove': drivers/video/tmiofb.c:811: warning:
initialization discards qualifiers from pointer target type
drivers/video/tmiofb.c: In function 'tmiofb_suspend':
drivers/video/tmiofb.c:941: warning: initialization discards
qualifiers from pointer target type drivers/video/tmiofb.c: In
function 'tmiofb_resume': drivers/video/tmiofb.c:973: warning:
initialization discards qualifiers from pointer target type

Introduced by commits 2a79bb1d72f5ac22dff96de340d90d512f852ecb
("mfd: mfd_cell is now implicitly available to tc6393xb drivers")
and b6361637190e6cb7acb84509499942ada69e7136 ("fb: Use mfd_data
instead of driver_data for tmio-fb").
Oops, this should fix that.


Actually, I noticed that I screwed this up for the other tmio drivers
as well.  Here's a patch that addresses them all (you can
ignore the previous patch).
Patch applied, thanks for fixing that.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help