[patch] backlight/pcf50633: check for NULL consistently in
From: Dan Carpenter <hidden>
Date: 2011-03-29 03:20:20
Also in:
kernel-janitors
Subsystem:
backlight class/subsystem, framebuffer layer, the rest · Maintainers:
Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller, Linus Torvalds
We checked "pdata" for NULL at the start of the function so we should check it here as well. Signed-off-by: Dan Carpenter <redacted> --- Compile tested only. Please review.
diff --git a/drivers/video/backlight/pcf50633-backlight.c b/drivers/video/backlight/pcf50633-backlight.c
index ef5628d..0fe934f 100644
--- a/drivers/video/backlight/pcf50633-backlight.c
+++ b/drivers/video/backlight/pcf50633-backlight.c@@ -136,7 +136,9 @@ static int __devinit pcf50633_bl_probe(struct platform_device *pdev) platform_set_drvdata(pdev, pcf_bl); - pcf50633_reg_write(pcf_bl->pcf, PCF50633_REG_LEDDIM, pdata->ramp_time); + if (pdata) + pcf50633_reg_write(pcf_bl->pcf, PCF50633_REG_LEDDIM, + pdata->ramp_time); /* Should be different from bl_props.brightness, so we do not exit * update_status early the first time it's called */