Re: [PATCH] mx3fb: Fix parameter to sdc_init_panel

On Monday 14 February 2011, 08:57:04 Guennadi Liakhovetski wrote:

On Mon, 14 Feb 2011, Alexander Stein wrote:

quoted

On Thursday 10 February 2011, 14:01:17 Alexander Stein wrote:

quoted

On Thursday 10 February 2011, 13:48:23 Guennadi Liakhovetski wrote:

quoted

quoted

I don't know which display you used, but I guess your right_margin
(and lower_margin) needs to be adjusted.

Ok, agree. But then you need to adjust all current users and have
them tested... Otherwise, of course, you can just adjust your
platform panel data to work with the current calculations, even
though in principle your patch seems to be doing the right thing
(tm), according to the manual. But if applied as is without fixing
all the users, it can very well break them...

Ok, I've just seen there are some model defines in mx3fb.c which would
also be affected.
I'll try to find all mx3fb users and fix their videomodes and repost a
new patch.

Uh, this seems next to impossible for me to handle it my own. I checked
some users of the mx3fb but I cant say which ones will be affected and
which ones not (e.g. without any hsync/vsync, on data enable).
I've not idea how to fix it then.

Well, you can, of course, adjust parameters for your platform to be able
to run with this incorrect parameter definition...

This is just an ugly work-around. Depending on the settings you may even get 
an overflow resulting in a not-working display at all.

Alexander