Thread (15 messages) 15 messages, 5 authors, 2011-02-10

Re: [PATCH 1/2] video: Add i.MX23/28 framebuffer driver

flat view
STALE5731d

From: Wolfram Sang <hidden>
Date: 2011-02-10 10:47:25
Also in: linux-arm-kernel

Possibly related (same subject, not in this thread)

But I would prefer:
#define SET 4
#define CLEAR 8
[...]
writel(CTRL_DOTCLK_MODE, host->base + CTRL + SET)
NACK.

This will indeed not be caught by the compiler.

And while I like the shorter macros better as well, an MXSFB_ prefix
should be added IMO. Macros like CTRL and TIMING are not too well
protected.

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help