[Patch] video: remove pointless comments in drivers/video/console/vgacon.c

Subsystems: console subsystem, framebuffer layer, the rest

STALE5694d

2 messages, 2 authors, 2011-01-19 · open the first message on its own page

[Patch] video: remove pointless comments in drivers/video/console/vgacon.c

From: Amerigo Wang <hidden>
Date: 2011-01-19 06:00:36

Now vgacon_scrollback_startup() uses slab, not bootmem,
so that comment is obsolete, the rest are useless.

Signed-off-by: WANG Cong <redacted>

---
diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c
index c97491b..b030aca 100644
--- a/drivers/video/console/vgacon.c
+++ b/drivers/video/console/vgacon.c
@@ -202,10 +202,6 @@ static void vgacon_scrollback_init(int pitch)
 	}
 }
 
-/*
- * Called only duing init so call of alloc_bootmen is ok.
- * Marked __init_refok to silence modpost.
- */
 static void __init_refok vgacon_scrollback_startup(void)
 {
 	vgacon_scrollback = kcalloc(CONFIG_VGACON_SOFT_SCROLLBACK_SIZE, 1024, GFP_NOWAIT);

Re: [Patch] video: remove pointless comments in drivers/video/console/vgacon.c

From: Paul Mundt <hidden>
Date: 2011-01-19 06:05:19

On Wed, Jan 19, 2011 at 02:00:02PM +0800, Amerigo Wang wrote:
Now vgacon_scrollback_startup() uses slab, not bootmem,
so that comment is obsolete, the rest are useless.

Signed-off-by: WANG Cong <redacted>
If you're going to do this then at least follow through and do the rest
of it. The comment is no longer applicable, but then neither is the
__init_refok annotation. Killing off the comment explaining why something
is (or was there) without killing off the thing that is referenced by the
comment is not terribly productive.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help