Re: [PATCH 3/4] s3c-fb: Add support S5PV310 FIMD
From: Paul Mundt <hidden>
Date: 2010-11-12 10:08:52
Also in:
linux-arm-kernel, linux-samsung-soc
On Fri, Nov 12, 2010 at 06:54:29PM +0900, Inki Dae wrote:
quoted hunk ↗ jump to hunk
@@ -1314,13 +1319,22 @@ static int __devinit s3c_fb_probe(structplatform_device *pdev) sfb->pdata = pd; sfb->variant = fbdrv->variant; - sfb->bus_clk = clk_get(dev, "lcd"); - if (IS_ERR(sfb->bus_clk)) { - dev_err(dev, "failed to get bus clock\n"); + /* if sclk_name is NULL then it would use bus clock as default. */ + if (!pd->sclk_name) + sfb->lcd_clk = clk_get(dev, "lcd"); + else + sfb->lcd_clk = clk_get(dev, pd->sclk_name); +
No, this is totally pointless. Simply establish a clk lookup for the configuration you are running on in your board code and always have clk_get() operate on a fixed id. You can use this same scheme with any optional clocks you have too, and reconfigure according to whether the lookups for optional clocks succeeded or not.