On Fri, Nov 12, 2010 at 12:47:15PM +0100, ext Samreen wrote:
quoted hunk ↗ jump to hunk
A null pointer check added.
Signed-off-by: Samreen <redacted>
---
drivers/video/omap2/omapfb/omapfb-main.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/video/omap2/omapfb/omapfb-main.c b/drivers/video/omap2/omapfb/omapfb-main.c
index 6a704f1..55bed89 100644
--- a/drivers/video/omap2/omapfb/omapfb-main.c
+++ b/drivers/video/omap2/omapfb/omapfb-main.c
@@ -2133,6 +2133,8 @@ static int omapfb_parse_def_modes(struct omapfb2_device *fbdev)
int r = 0;
str = kmalloc(strlen(def_mode) + 1, GFP_KERNEL);
+ if (str = NULL)
+ return -EINVAL;
strcpy(str, def_mode);
While you're at it you could change the code to use kstrdup().
--
Ville Syrjälä