Re: [PATCH] rivafb: dubious assignment
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2010-10-22 14:47:06
Also in:
lkml
On Fri, Oct 22, 2010 at 13:31, Nicolas Kaiser [off-list ref] wrote:
quoted hunk ↗ jump to hunk
A duplicated assignment unconditionally changes max_gfsize to GFIFO_SIZE. It looks to me like this might not be intended, or is it? Signed-off-by: Nicolas Kaiser <redacted> --- drivers/video/riva/riva_hw.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)diff --git a/drivers/video/riva/riva_hw.c b/drivers/video/riva/riva_hw.c index 78fdbf5..936abfa 100644 --- a/drivers/video/riva/riva_hw.c +++ b/drivers/video/riva/riva_hw.c@@ -263,7 +263,6 @@ static int nv3_iterate(nv3_fifo_info *res_info, nv3_sim_state * state, nv3_arb_ivmisses = 2; if (ainfo->gburst_size = 128) max_gfsize = GFIFO_SIZE_128; else max_gfsize = GFIFO_SIZE; - max_gfsize = GFIFO_SIZE; while (1) { if (ainfo->vid_en) -- 1.7.2.2
According to full-history-linux, this comes from the initial drop in 2.3.49pre2,
from nVidia code(?), imported by Jeff Garzik.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds