[PATCH] rivafb: dubious assignment

Subsystems: framebuffer layer, the rest

STALE5810d

3 messages, 3 authors, 2010-10-22 · open the first message on its own page

[PATCH] rivafb: dubious assignment

From: Nicolas Kaiser <hidden>
Date: 2010-10-22 11:32:39

A duplicated assignment unconditionally changes max_gfsize to
GFIFO_SIZE.

It looks to me like this might not be intended, or is it?

Signed-off-by: Nicolas Kaiser <redacted>
---
 drivers/video/riva/riva_hw.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/video/riva/riva_hw.c b/drivers/video/riva/riva_hw.c
index 78fdbf5..936abfa 100644
--- a/drivers/video/riva/riva_hw.c
+++ b/drivers/video/riva/riva_hw.c
@@ -263,7 +263,6 @@ static int nv3_iterate(nv3_fifo_info *res_info, nv3_sim_state * state, nv3_arb_i
     vmisses = 2;
     if (ainfo->gburst_size = 128) max_gfsize = GFIFO_SIZE_128;
     else  max_gfsize = GFIFO_SIZE;
-    max_gfsize = GFIFO_SIZE;
     while (1)
     {
         if (ainfo->vid_en)
-- 
1.7.2.2

Re: [PATCH] rivafb: dubious assignment

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2010-10-22 14:47:06

On Fri, Oct 22, 2010 at 13:31, Nicolas Kaiser [off-list ref] wrote:
quoted hunk
A duplicated assignment unconditionally changes max_gfsize to
GFIFO_SIZE.

It looks to me like this might not be intended, or is it?

Signed-off-by: Nicolas Kaiser <redacted>
---
 drivers/video/riva/riva_hw.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/video/riva/riva_hw.c b/drivers/video/riva/riva_hw.c
index 78fdbf5..936abfa 100644
--- a/drivers/video/riva/riva_hw.c
+++ b/drivers/video/riva/riva_hw.c
@@ -263,7 +263,6 @@ static int nv3_iterate(nv3_fifo_info *res_info, nv3_sim_state * state, nv3_arb_i
    vmisses = 2;
    if (ainfo->gburst_size = 128) max_gfsize = GFIFO_SIZE_128;
    else  max_gfsize = GFIFO_SIZE;
-    max_gfsize = GFIFO_SIZE;
    while (1)
    {
        if (ainfo->vid_en)
--
1.7.2.2
According to full-history-linux, this comes from the initial drop in 2.3.49pre2,
from nVidia code(?), imported by Jeff Garzik.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] rivafb: dubious assignment

From: Jeff Garzik <hidden>
Date: 2010-10-22 17:19:00

On 10/22/2010 10:47 AM, Geert Uytterhoeven wrote:
On Fri, Oct 22, 2010 at 13:31, Nicolas Kaiser[off-list ref]  wrote:
quoted
A duplicated assignment unconditionally changes max_gfsize to
GFIFO_SIZE.

It looks to me like this might not be intended, or is it?

Signed-off-by: Nicolas Kaiser<redacted>
---
  drivers/video/riva/riva_hw.c |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/video/riva/riva_hw.c b/drivers/video/riva/riva_hw.c
index 78fdbf5..936abfa 100644
--- a/drivers/video/riva/riva_hw.c
+++ b/drivers/video/riva/riva_hw.c
@@ -263,7 +263,6 @@ static int nv3_iterate(nv3_fifo_info *res_info, nv3_sim_state * state, nv3_arb_i
     vmisses = 2;
     if (ainfo->gburst_size = 128) max_gfsize = GFIFO_SIZE_128;
     else  max_gfsize = GFIFO_SIZE;
-    max_gfsize = GFIFO_SIZE;
     while (1)
     {
         if (ainfo->vid_en)
--
1.7.2.2
According to full-history-linux, this comes from the initial drop in 2.3.49pre2,
from nVidia code(?), imported by Jeff Garzik.
Yep, came straight from X.org driver code...   Patch certainly looks 
correct, but who knows but NV for sure :)

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help