Nilofer, Samreen wrote:

Hi,

Hiremath, Vaibhav wrote:

quoted

quoted

-----Original Message-----
From: Tomi Valkeinen [mailto:tomi.valkeinen@nokia.com]
Sent: Wednesday, October 20, 2010 6:22 PM
To: Nilofer, Samreen
Cc: Grazvydas Ignotas; Hiremath, Vaibhav; Quadros Roger (Nokia-
MS/Helsinki); Guruswamy, Senthilvadivu; linux-omap@vger.kernel.org;
linux- fbdev@vger.kernel.org Subject: Re: [PATCH v3] OMAP3: DSS:
Kconfig changes to enable display options on OMAP3

Hi,

On Wed, 2010-10-20 at 14:04 +0200, ext Samreen wrote:

quoted

The defconfig options for display are taken in the respective
Kconfig to enable display by default on OMAP3 platforms

Signed-off-by: Samreen <redacted>
---
 Version3:
       Eliminate the separate default number of FBs for different
architecture. Keeping default FBs as 3 as before.

 Version2:
        Enables by default NEC panel used in zoom2/3/3630sdp,
instead of  Sharp LQ043T1DG01 panel enabled in previous version of this
patch 

 drivers/video/omap2/displays/Kconfig |    3 +++
 drivers/video/omap2/dss/Kconfig      |    6 ++++--
 drivers/video/omap2/omapfb/Kconfig   |    1 +
 3 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/video/omap2/displays/Kconfig

b/drivers/video/omap2/displays/Kconfig

quoted

index f8152cf..d818e44 100644

--- a/drivers/video/omap2/displays/Kconfig
+++ b/drivers/video/omap2/displays/Kconfig

@@ -3,6 +3,7 @@ menu "OMAP2/3 Display Device Drivers"

 config PANEL_GENERIC
         tristate "Generic Panel"
+	default y
         help
 	  Generic panel driver.
 	  Used for DVI output for Beagle and OMAP3 SDP.

@@ -10,6 +11,7 @@ config PANEL_GENERIC  config

PANEL_SHARP_LS037V7DW01
         tristate "Sharp LS037V7DW01 LCD Panel"
         depends on OMAP2_DSS
+	default y
         select BACKLIGHT_CLASS_DEVICE
         help
           LCD Panel used in TI's SDP3430 and EVM boards @@ -23,6
+25,7 @@ config PANEL_SHARP_LQ043T1DG01  config
PANEL_NEC_NL8048HL11_01B
 	tristate "NEC NL8048HL11-01B Panel"
 	depends on OMAP2_DSS
+	default y
 	help
 		This NEC NL8048HL11-01B panel is TFT LCD
 		used in the Zoom2/3/3630 sdp boards.

What kernel is this based on? There's no Nec driver on my or Linus' tree.

If you enable those panels by default, why not enable all the rest of
the panels also? And should DSI/SDI/RFBI be enabled also by default,
and all the panels that require those? Where do we draw the line?

I feel the only sane options are to keep everything off by default,
or all on by default. And setting all on by default doesn't sound too good
either... 

[Hiremath, Vaibhav] I agree with Tomi here.

Thanks,
Vaibhav

[Samreen]
Tomi,
     I have sent a separate patch "OMAP: DSS2: Add NEC
NL8048HL11-01B display panel" that adds the nec panel to L-O
mailing list. On top of which I have sent these patches. I am
using the LO-dss2 tree to verify my patches.

[Samreen]
   With the patch link for reference:
http://marc.info/?t8766436100002&r=1&w=2
Warm Regards,
Samreen

Tomi/Vaibav,
     As keeping the panel disable by default is a better
idea, I will rework my patches accordingly.

quoted

quoted

quoted

diff --git a/drivers/video/omap2/dss/Kconfig

b/drivers/video/omap2/dss/Kconfig

quoted

index 43b6440..f3244a2 100644

--- a/drivers/video/omap2/dss/Kconfig
+++ b/drivers/video/omap2/dss/Kconfig

@@ -1,6 +1,7 @@
 menuconfig OMAP2_DSS
         tristate "OMAP2/3 Display Subsystem support (EXPERIMENTAL)"
         depends on ARCH_OMAP2 || ARCH_OMAP3
+	default y
         help
           OMAP2/3 Display Subsystem support.

@@ -9,7 +10,7 @@ if OMAP2_DSS
 config OMAP2_VRAM_SIZE
 	int "VRAM size (MB)"
 	range 0 32
-	default 0
+	default 4
 	help
 	  The amount of SDRAM to reserve at boot time for video RAM use.
 	  This VRAM will be used by omapfb and other drivers that need @@
-102,7 +103,8 @@ config OMAP2_DSS_FAKE_VSYNC  config
 	OMAP2_DSS_MIN_FCK_PER_PCK int "Minimum FCK/PCK ratio (for scaling)" 

range 0 32 -	default 0
+	default 4  if ARCH_OMAP2 || ARCH_OMAP3
+	default 0  if ARCH_OMAP4

Why is the ratio set to 4 on all OMAP2/3 boards?

 Tomi

[Samreen]
    With the ratio as 4, a downscaling of 1/4 & 1/8 is
achieved with RGB & Yuv formats.
This is would be optimal value to achieve both upscaling and downscale
together.