Thread (7 messages) 7 messages, 3 authors, 2010-09-22

Re: [PATCH] viafb: Use proper register for bgcolor when doing MONO

From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Date: 2010-09-21 20:31:16

Hi,

Jon Nettleton schrieb:
On Tue, Sep 21, 2010 at 10:07 AM, Daniel Drake [off-list ref] wrote:
quoted
On 21 September 2010 18:00, Florian Tobias Schandinat
[off-list ref] wrote:
quoted
Not really. For color blits it looks like we're doing the right thing here,
Yes you are but the code says.

 if (op = VIA_BITBLT_MONO)
I wrote a little test case:
 >>> colortest.sh
#!/bin/sh

echo -e "\033[30;47mblit: BLACK_ON_WHITE\033[0m"
echo -e "\033[37;40mblit: WHITE_ON_BLACK\033[0m"
echo -e "\033[31;44mbilt: RED_ON_BLUE\033[0m"
echo -e "fillrect: YELLOW\033[43m"
sleep 5
clear
echo -e "\033[0m"
<<<
The first three cases behaved on VX800 as well as XO 1.5 (with stock kernel as 
well as self-compiled) as expected, only the last went wrong (the cleared 
background was black instead yellow). Yes that is a bug but nut anything in the 
blitting code but in the VIA_BITBLT_FILL code where I admit that we write the 
colour to the wrong register. Will try to get a proper patch for that in the 
next few days (although I'm very, very busy at the moment).


Thanks,

Florian Tobias Schandinat
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help