RE: [PATCH 01/19] s3c-fb: Change to depending on CONFIG_S3C_FB_DEV
From: Pawel Osciak <hidden>
Date: 2010-07-09 11:55:38
Also in:
linux-arm-kernel, linux-samsung-soc
Kukjin Kim [off-list ref]: Pawel Osciak wrote:quoted
From: Ben Dooks <ben-linux@fluff.org> As suggested by Marek Szyprowski, we should make the driver depend on the configuration currently being used to build the platform device into the kernel. Signed-off-by: Ben Dooks <ben-linux@fluff.org> Signed-off-by: Pawel Osciak <redacted>Actually, already submitted by Ben Dooks. http://lists.infradead.org/pipermail/linux-arm-kernel/2010-May/015616.html So...I'm not sure adding your signedoff and re-submitting are right. In my opinion, it's enough to add comments which includes information about that without re-submitting.
Adding signoffs is a normal procedure when submitting somebody else's patches with their permission. The problem here is that I wasn't aware of them being already posted, there must've been a miscommunication between me and Ben when I asked him if it was ok to submit his patches along with mine. Sorry Ben! Anyway, thank you for pointing this out. Of course, my sign-offs can be removed from the first 7 patches. Best regards -- Pawel Osciak Linux Platform Group Samsung Poland R&D Center
quoted
--- drivers/video/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig index 3d94a14..858f1ca 100644 --- a/drivers/video/Kconfig +++ b/drivers/video/Kconfig@@ -1930,7 +1930,7 @@ config FB_TMIO_ACCELL config FB_S3C tristate "Samsung S3C framebuffer support" - depends on FB && ARCH_S3C64XX + depends on FB && S3C_DEV_FB select FB_CFB_FILLRECT select FB_CFB_COPYAREA select FB_CFB_IMAGEBLIT --Thanks. Best regards, Kgene. -- Kukjin Kim [off-list ref], Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.