Ben Dooks [off-list ref] wrote:
On 28/06/10 09:08, Pawel Osciak wrote:

quoted

@@ -819,7 +820,8 @@ static void s3c_fb_release_win(struct s3c_fb *sfb,

struct s3c_fb_win *win)

quoted

 {
 	if (win->fbinfo) {
 		unregister_framebuffer(win->fbinfo);
-		fb_dealloc_cmap(&win->fbinfo->cmap);
+		if (&win->fbinfo->cmap)
+			fb_dealloc_cmap(&win->fbinfo->cmap);

did you really mean &win->fbinfo->cmap? surely that will end up
always evaluating to true?

It should have actually been:

+		if (win->fbinfo->cmap.len)
+			fb_dealloc_cmap(&win->fbinfo->cmap);

Thanks, will post a fix for this patch.


Best regards
--
Pawel Osciak
Linux Platform Group
Samsung Poland R&D Center