Re: [PATCH] OMAP:DSS2:OMAPFB: Fix probe error path

Hi,

On Wed, 2010-06-30 at 16:15 +0200, ext Afzal Mohammed wrote:

If enabling fb0 fails in omapfb_create_framebuffers(), remove
sysfs file before returning to probe. This is required to complete
the cleanup in the above mentioned error case.

omapfb frees the resources in omapfb_free_resources(). I believe
removing sysfs should also be put into omapfb_free_resources() to be
consistent, and not as an explicit call like in this patch.

However, I'm not sure if some sysfs-allocated flag is needed for this to
work in all cases.

 Tomi