On Sat, 1 May 2010, Magnus Damm wrote:

On Sat, May 1, 2010 at 9:15 PM, Guennadi Liakhovetski
[off-list ref] wrote:

quoted

On Sat, 1 May 2010, Magnus Damm wrote:

quoted

On Sat, May 1, 2010 at 1:07 AM, Guennadi Liakhovetski
[off-list ref] wrote:

quoted

The SH LCDC driver can also function without the IRQ, in which case the
FBIO_WAITFORVSYNC ioctl() cannot be supported. Enable such a mode.

Signed-off-by: Guennadi Liakhovetski <redacted>

Why? Doesn't the LCDC hardware block always come with an IRQ line?

Because on AP4 intcs is not supported in the mainline yet. And because we
can?;) Some code paths in the driver already care for the case, when no
IRQ is configured, so, we can just use it.

Patches for INTCS have been posted for SH-Mobile ARM G3/G4/AP4. They
will be part of the upcoming .35 release. The merge order dependencies
are a bit tricky, so please apply whatever needed locally for now.

Ah, sorry, I must have missed those patches. Sure, then just drop this 
patch.

I don't agree with you that allowing people to not hook up an IRQ is a
good thing. The driver already has too many different modes of
operation, adding another one will just make it more error prone.
Trying to reduce the number of special cases is the way forward, not
making yet another one...

Thanks for the LCDC fixes though!

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/