Re: [PATCH v2 2/6] hid: add framebuffer support to PicoLCD device
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2010-03-21 03:25:30
Also in:
linux-input, lkml
On Sat, Mar 20, 2010 at 05:04:15PM +0100, Bruno Prémont wrote:
+static inline int picolcd_fb_send_tile(struct hid_device *hdev, int chip,
+ int tile)
+{You seemt o be fond of the 'inline; attribute ;) I don't think that a 40 lines function qualifies. Please lose inlines on functions that are not in .h files and are not stubs. -- Dmitry