Re: [PATCH 00/02] sh: Panning fixes
From: Magnus Damm <magnus.damm@gmail.com>
Date: 2010-02-15 10:33:22
Also in:
linux-sh
Hi Phil, On Mon, Feb 15, 2010 at 5:41 PM, Phil Edworthy [off-list ref] wrote:
quoted
quoted
quoted
Thanks for your patches. Please make sure that the SYS panel case with deferred io is working. Migo-R is a good board to test this on.I thought the Migo-R doesn't have vsync connected to the SH, so maybethisquoted
patch won't show any difference. Is that your understanding?Something like that, I think the QVGA LCD panel on Migo-R does not expose the VSYNC pin of the on-panel LCD controller so there is nothing to connect to the sh7722.That's what I thought.
So there will be tearing on Migo-R regardless how smart our software is...
quoted
It may be difficult to test your patch because of this, I'm not sure. My main concern was just to double check that you've thought about dealing with both the deferred io case and the "regular" non-deferred io case. The sh7724 KFR2R09 board is using deferred io and I think some upcoming boards may make use of that as well, so I'd prefer to keep that case working. =)How do you want to proceed then? I can't say that I am familiar with deferred io and I don't have a board I can test it on... Is there anyone you know who can try this?
... but it should be possible to test on Migo-R even though the vsync pin is missing. Usually people who submit patches do the testing to make sure other platforms won't break. I realize that it may be difficult for you if you don't have any platform to test on. I may be able to find a Migo-R board somewhere, and I'd be happy to add this to my TODO list. Beware that my list is pretty long, so if you're in a rush then I suggest you to test yourself or find someone else to do it for you. Cheers, / magnus