Re: [PATCH] video/matrox: Checkpatch cleanups for matroxfb_crtc2.c
From: Jean Delvare <hidden>
Date: 2010-01-18 21:11:53
Also in:
kernel-janitors, lkml
From: Jean Delvare <hidden>
Date: 2010-01-18 21:11:53
Also in:
kernel-janitors, lkml
On Mon, 18 Jan 2010 11:59:30 -0800, Joe Perches wrote:
On Mon, 2010-01-18 at 20:27 +0100, Peter Hüwe wrote:quoted
the reason behind this change was that spaces and tabs were mixed for indention.Checkpatch isn't gospel and isn't always right. There should be room for taste preference here and I think whatever Petr V's is should prevail.quoted
How about this indention? Would this be better?Well, I don't think so, but others will have different opinions.
I don't see it as an improvement either. Was checkpatch.pl really complaining about the alignment? Tabs followed by less than 8 spaces is acceptable and fairly common AFAICT, I can't remember the script yelling at me when I do it. -- Jean Delvare