RE: [PATCH 01/15] OMAP: DSS2: DSI: fix VC channels in send_short
From: Aguirre, Sergio <hidden>
Date: 2010-01-08 13:29:49
Also in:
linux-omap
Tomi,
quoted hunk ↗ jump to hunk
-----Original Message----- From: linux-omap-owner@vger.kernel.org [mailto:linux-omap- owner@vger.kernel.org] On Behalf Of Tomi Valkeinen Sent: Friday, January 08, 2010 7:23 AM To: linux-omap@vger.kernel.org; linux-fbdev@vger.kernel.org Cc: Tomi Valkeinen Subject: [PATCH 01/15] OMAP: DSS2: DSI: fix VC channels in send_short and send_null - dsi_vc_send_short() needs to use dest_per for the peripheral id - dsi_vc_send_null() was always using channel id 0 Signed-off-by: Tomi Valkeinen <redacted> --- drivers/video/omap2/dss/dsi.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)diff --git a/drivers/video/omap2/dss/dsi.c b/drivers/video/omap2/dss/dsi.c index 5936487..c37bc5b 100644 --- a/drivers/video/omap2/dss/dsi.c +++ b/drivers/video/omap2/dss/dsi.c@@ -1999,7 +1999,8 @@ static int dsi_vc_send_short(int channel, u8data_type, u16 data, u8 ecc) return -EINVAL; } - data_id = data_type | channel << 6; + /* data_id = data_type | channel << 6; */
Why do you need this old line commented? Regards, Sergio
quoted hunk ↗ jump to hunk
+ data_id = data_type | dsi.vc[channel].dest_per << 6; r = (data_id << 0) | (data << 8) | (ecc << 24);@@ -2011,7 +2012,7 @@ static int dsi_vc_send_short(int channel, u8data_type, u16 data, u8 ecc) int dsi_vc_send_null(int channel) { u8 nullpkg[] = {0, 0, 0, 0}; - return dsi_vc_send_long(0, DSI_DT_NULL_PACKET, nullpkg, 4, 0); + return dsi_vc_send_long(channel, DSI_DT_NULL_PACKET, nullpkg, 4, 0); } EXPORT_SYMBOL(dsi_vc_send_null); -- 1.6.5 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html