Re: [PATCH] hid: Logitech G13 driver 0.0.3

On Friday 08 January 2010 09:13:29 am Greg KH wrote:

On Fri, Jan 08, 2010 at 06:04:50PM +0100, Pavel Machek wrote:

quoted

On Fri 2010-01-08 09:50:33, Rick L. Vinyard, Jr. wrote:

quoted

Pavel Machek wrote:

quoted

Hi!

quoted

quoted

+static DEVICE_ATTR(name, 0666, g13_name_show, g13_name_store);

What this attribute is for?

Actually, all the new files this added need to be documented.

Which is better? A hid-g13.txt file added to Documentation/ or comments
in the driver itself?

Documentation. Coordinate with sysfs maintainer (gregkh).

All sysfs files need to be documented in Documentation/ABI/  Please add
the documentation there for your new sysfs files.

We need to have an agreement that all of them are needed first though.

-- 
Dmitry