RE: [PATCH 5/5] OMAP3EVM: Kconfig option added for selection

-----Original Message-----
From: Randy Dunlap [mailto:randy.dunlap@oracle.com]
Sent: Thursday, December 17, 2009 10:13 PM
To: Hiremath, Vaibhav
Cc: tomi.valkeinen@nokia.com; linux-omap@vger.kernel.org; linux-
fbdev-devel@lists.sourceforge.net; linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 5/5] OMAP3EVM: Kconfig option added for
selection between SVIDEO and CVBS

On Thu, 17 Dec 2009 20:49:36 +0530 hvaibhav@ti.com wrote:

quoted

From: Vaibhav Hiremath <redacted>

Config option added to arch/arm/plat-omap/Kconfig for selection
of S-Video and Composite output interfaces. The default

configuration would

quoted

be S-Video.

Signed-off-by: Vaibhav Hiremath <redacted>
---
 arch/arm/mach-omap2/board-omap3evm.c |    4 ++++
 drivers/video/omap2/dss/Kconfig      |   15 +++++++++++++++
 2 files changed, 19 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach-

omap2/board-omap3evm.c

quoted

index e615254..549e58e 100644

--- a/arch/arm/mach-omap2/board-omap3evm.c
+++ b/arch/arm/mach-omap2/board-omap3evm.c

@@ -275,7 +275,11 @@ static struct omap_dss_device

omap3_evm_tv_device = {

quoted

 	.name			= "tv",
 	.driver_name		= "venc",
 	.type			= OMAP_DISPLAY_TYPE_VENC,
+#if defined(CONFIG_OMAP2_VENC_OUT_TYPE_SVIDEO)
 	.phy.venc.type		= OMAP_DSS_VENC_TYPE_SVIDEO,
+#elif defined(CONFIG_OMAP2_VENC_OUT_TYPE_COMPOSITE)
+	.u.venc.type		= OMAP_DSS_VENC_TYPE_COMPOSITE,

	.u or .phy ?

[Hiremath, Vaibhav] Good catch; and this must be last minute cleanup of patch for submission. I have attached updated/fixed version here with this mail.

Thanks,
Vaibhav

quoted

+#endif
 	.platform_enable	= omap3_evm_enable_tv,
 	.platform_disable	= omap3_evm_disable_tv,
 };

---
~Randy