Thread (7 messages) 7 messages, 2 authors, 2009-11-23

Re: [PATCH 7/8] pxa: add frame buffer on pxa168 aspenite platform

flat view
STALE6166d

From: Eric Miao <hidden>
Date: 2009-11-19 16:29:23
Also in: linux-arm-kernel

quoted hunk ↗ jump to hunk
+ Β  Β  Β  int err = 0;
+ Β  Β  Β  if (on) {
+ Β  Β  Β  Β  Β  Β  Β  if (spi_gpio_reset != -1) {
+ Β  Β  Β  Β  Β  Β  Β  Β  Β  Β  Β  err = gpio_request(spi_gpio_reset, "TPO_LCD_SPI_RESET");
+ Β  Β  Β  Β  Β  Β  Β  Β  Β  Β  Β  if (err) {
+ Β  Β  Β  Β  Β  Β  Β  Β  Β  Β  Β  Β  Β  Β  Β  printk(KERN_ERR "failed to request GPIO for TPO LCD RESET\n");
+ Β  Β  Β  Β  Β  Β  Β  Β  Β  Β  Β  Β  Β  Β  Β  return err;
+ Β  Β  Β  Β  Β  Β  Β  Β  Β  Β  Β  }
+ Β  Β  Β  Β  Β  Β  Β  Β  Β  Β  Β  gpio_direction_output(spi_gpio_reset, 0);
+ Β  Β  Β  Β  Β  Β  Β  Β  Β  Β  Β  msleep(100);
This is really a loooong delay, there any specific reason for such a long
delay, I'm seeing this to slow down the boot up significantly?

Otherwise looks OK to me, and I prefer the defconfig file change to
be a separate patch please.
�τθΊ{.nΗ+‰·�®‰­†+%�Λ�±ιέ¶¥�w�Ί{.nΗ+‰·¥�{±ύφέz�β�Ψ^n‡r΅φ¦zΛ�λh™¨θ­Ϊ&£ϋΰzΏδzΉή—ϊ+€Κ+zf£Ά·h��§~†­†Ϋi��ο�κ�‘κηz_θ®ζj:+v‰¨ώ)ί£ψm
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help