Re: [patch] fix oops with no /proc
From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Date: 2009-11-25 17:46:56
Hi, nice catch. Your patch is obviously correct. Please send it to Andrew Morton [off-list ref] to get it into mainline. Dan Carpenter schrieb:
Fixed a typo: missing *. This would lead to a kernel oops if the kernel was compiled without support for the /proc file system. Found with a static checker. Compile tested. regards, dan carpenter Signed-off-by: Dan Carpenter <redacted>
Acked-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
quoted hunk ↗ jump to hunk
--- orig/drivers/video/via/viafbdev.c 2009-11-21 14:44:33.000000000 +0200 +++ devel/drivers/video/via/viafbdev.c 2009-11-21 14:44:43.000000000 +0200@@ -1797,7 +1797,7 @@ static const struct file_operations viaf static void viafb_init_proc(struct proc_dir_entry **viafb_entry) { *viafb_entry = proc_mkdir("viafb", NULL); - if (viafb_entry) { + if (*viafb_entry) {
Thanks, Florian Tobias Schandinat ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july