Re: [PATCH v2 3/3] drm/kms: allocate framebuffer cmap
From: James Simmons <hidden>
Date: 2009-11-03 17:19:14
Also in:
lkml
quoted hunk ↗ jump to hunk
Without an allocated colormap, FBIOGETCMAP fails. This would make programs restore an all-black colormap ("links -g") or fail to work altogether ("mplayer -vo fbdev2"). Signed-off-by: Clemens Ladisch <clemens@ladisch.de> --- v2: implemented suggestions by James Simmons drivers/gpu/drm/drm_fb_helper.c | 4 ++++ 1 file changed, 4 insertions(+)--- linux-2.6/drivers/gpu/drm/drm_fb_helper.c +++ linux-2.6/drivers/gpu/drm/drm_fb_helper.c@@ -905,6 +905,9 @@ int drm_fb_helper_single_fb_probe(struct if (new_fb) { info->var.pixclock = 0; + ret = fb_alloc_cmap(&info->cmap, crtc->gamma_size, 0); + if (ret) + return ret;
if (register_framebuffer(info) < 0) {fb_dealloc_cmap(info->cmap);
return -EINVAL;
} Plug memory leak.
quoted hunk ↗ jump to hunk
} else {@@ -936,6 +939,7 @@ void drm_fb_helper_free(struct drm_fb_he unregister_sysrq_key('v', &sysrq_drm_fb_helper_restore_op); } drm_fb_helper_crtc_free(helper); + fb_dealloc_cmap(&helper->fb->fbdev->cmap); } EXPORT_SYMBOL(drm_fb_helper_free); ------------------------------------------------------------------------------Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel