Re: [PATCH 4/4] video: add driver for PXA3xx 2D graphics accelerator

On Wed, Jul 22, 2009 at 02:04:33PM +0200, Daniel Mack wrote:

On Mon, Jul 20, 2009 at 10:45:35PM +0800, Eric Miao wrote:

quoted

Daniel Mack wrote:

quoted

quoted

Cool - I'll find a time slot to test this, and maybe someone else wants to
have a try either. Thanks.

Will that accelerator ID patch (the one I sent today) go thru your
channel or are the fbdev people supposed to pick it?

Better to go through fbdev people - or at least I need an Ack before it
goes through my tree.

Krzysztof Cc'ed.

Krzysztof,

resending this because I don't known whether you got the first copy of
that patch.

I'm sending this patch for the the forth time now, this time with the
fbdev-devel list copied. Maybe that helps.

This is fairly simple, but it's blocking the pxa3xx-gcu driver to be
merged.

Any feedback is appreciated.

Thanks,
Daniel

From 8b200756251e3dcdc91d506e9dbc9846ccaa91d3 Mon Sep 17 00:00:00 2001
From: Daniel Mack <redacted>
Date: Mon, 20 Jul 2009 11:18:43 +0200
Subject: [PATCH] video: add PXA3xx accelerator ID

Add ID 99 for PXA3xx frame buffers and use it in pxafb when running on a
pxa with acceleration enabled.

Signed-off-by: Daniel Mack <redacted>
Cc: Eric Miao <redacted>
Cc: linux-fbdev-devel@lists.sourceforge.net
Cc: Dennis Oliver Kropp <redacted>
Cc: Sven Neumann <redacted>
---
 drivers/video/pxafb.c |    5 +++++
 include/linux/fb.h    |    1 +
 2 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/drivers/video/pxafb.c b/drivers/video/pxafb.c
index 3951cc5..922ed8a 100644
--- a/drivers/video/pxafb.c
+++ b/drivers/video/pxafb.c

@@ -2083,6 +2083,11 @@ static int __devinit pxafb_probe(struct platform_device *dev)
 		goto failed;
 	}
 
+#ifdef CONFIG_PXA3XX_GCU
+	if (cpu_is_pxa3xx())
+		fbi->fb.fix.accel = FB_ACCEL_PXA3XX;
+#endif
+
 	fbi->backlight_power = inf->pxafb_backlight_power;
 	fbi->lcd_power = inf->pxafb_lcd_power;
 

diff --git a/include/linux/fb.h b/include/linux/fb.h
index f847df9..a34bdf5 100644
--- a/include/linux/fb.h
+++ b/include/linux/fb.h

@@ -133,6 +133,7 @@ struct dentry;
 #define FB_ACCEL_NEOMAGIC_NM2230 96	/* NeoMagic NM2230              */
 #define FB_ACCEL_NEOMAGIC_NM2360 97	/* NeoMagic NM2360              */
 #define FB_ACCEL_NEOMAGIC_NM2380 98	/* NeoMagic NM2380              */
+#define FB_ACCEL_PXA3XX		 99	/* PXA3xx			*/
 
 #define FB_ACCEL_SAVAGE4        0x80	/* S3 Savage4                   */
 #define FB_ACCEL_SAVAGE3D       0x81	/* S3 Savage3D                  */

-- 
1.6.3.1