Re: [PATCH 3/3] atyfb: Coding style cleanup
flat view
From: H Hartley Sweeten <hidden>
Date: 2009-06-23 16:53:10
On Saturday, June 20, 2009 2:30 PM, Ville Syrjala wrote:
quoted hunk ↗ jump to hunk
Fix a bunch of coding style problems in atyfb_base.c. Signed-off-by: Ville Syrjala <syrjala@sci.fi> --- There are still some problems left, at least over 80 char lines, but fixing those in a decent manner would require some code restructuring to reduce the overly deep nesting. I decided to leave those bits mostly untouched for now. drivers/video/aty/atyfb_base.c | 829 ++++++++++++++++++++++------------------ 1 files changed, 458 insertions(+), 371 deletions(-)diff --git a/drivers/video/aty/atyfb_base.c b/drivers/video/aty/atyfb_base.c index 63d3739..913b4a4 100644 --- a/drivers/video/aty/atyfb_base.c +++ b/drivers/video/aty/atyfb_base.c@@ -132,7 +132,7 @@ #endif #define PRINTKI(fmt, args...) printk(KERN_INFO "atyfb: " fmt, ## args) -#define PRINTKE(fmt, args...) printk(KERN_ERR "atyfb: " fmt, ## args) +#define PRINTKE(fmt, args...) printk(KERN_ERR "atyfb: " fmt, ## args)
Why not: #define pr_fmt(fmt) "atyfb: " fmt Then just use pr_info() and pr_err()? Also, pr_devel() could be used instead of the private DPRINTK() definition. Regards, Hartley ------------------------------------------------------------------------------ Are you an open source citizen? Join us for the Open Source Bridge conference! Portland, OR, June 17-19. Two days of sessions, one day of unconference: $250. Need another reason to go? 24-hour hacker lounge. Register today! http://ad.doubleclick.net/clk;215844324;13503038;v?http://opensourcebridge.org