Re: [Linux-fbdev-devel] [PATCH] omapfb: invalid test on unsigned
flat view
From: Krzysztof Helt <hidden>
Date: 2009-06-22 19:35:14
Also in:
linux-omap
On Mon, 22 Jun 2009 22:35:59 +0200 Roel Kluin [off-list ref] wrote:
Unsigned regno cannot be less than 0. Signed-off-by: Roel Kluin <redacted> --- Is this correct? please review.
No. It is a case for truecolor modes. They do not use the cmap.
Either remove the if clause completely or make it a an else clause for the next if
if (regno < 16) {
...
} else {
r = -EINVAL;
}
The latter (the else clause) is a better solution.
Kind regards,
Krzysztof
quoted hunk ↗ jump to hunk
diff --git a/drivers/video/omap/omapfb_main.c b/drivers/video/omap/omapfb_main.c index 060d72f..787271f 100644 --- a/drivers/video/omap/omapfb_main.c +++ b/drivers/video/omap/omapfb_main.c@@ -276,7 +276,7 @@ static int _setcolreg(struct fb_info *info, u_int regno, u_int red, u_int green, if (r != 0) break; - if (regno < 0) { + if (regno >= info->cmap.len) { r = -EINVAL; break; } ------------------------------------------------------------------------------Are you an open source citizen? Join us for the Open Source Bridge conference! Portland, OR, June 17-19. Two days of sessions, one day of unconference: $250. Need another reason to go? 24-hour hacker lounge. Register today! http://ad.doubleclick.net/clk;215844324;13503038;v?http://opensourcebridge.org _______________________________________________ Linux-fbdev-devel mailing list Linux-fbdev-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel
---------------------------------------------------------------------- Nowa akcja Pepsi - nagrody za kody spod nakretek. Zarejestruj sie! http://link.interia.pl/f21cc