Re: [PATCH] [drivers] [fb] S3C-fb: PM fix

Hello,

On Thursday, May 28, 2009 8:33 AM Andrew Morton wrote:

On Mon, 18 May 2009 08:05:46 +0200 Marek Szyprowski
[off-list ref] wrote:

quoted

Restore correctly FrameBuffer registers state in resume function.

Reviewed-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
[...]

What are the consequences of the bug whcih you fixed?  Device
inoperative after resume, I assume?  Does it affect all supported
hardware, or just some particualr device(s)?

Yes, the framebuffer was inoperative after resume. This bug was triggered on
a system that has a power management circuit which disabled power in most
S3C SOC power domains in suspend mode. In such case drivers need to restore
all its registers state after resume.

See, this is the sort of information whcih shuld be in the changelog,
please, so I (and others) can make decisions about which kernel
version(s) the patch should be merged into.

Ok. I will describe my patches more in detail in the future. Thanks for your
comments.

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center



------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT 
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, & 
iPhoneDevCamp as they present alongside digital heavyweights like Barbarian 
Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com