Re: [PATCH] fbdev: does not allow VESA modes without compiled-in drivers (bug #13249)
From: Andrew Morton <akpm@linux-foundation.org>
Date: 2009-05-27 06:16:07
On Wed, 20 May 2009 14:27:04 +0200 Krzysztof Helt [off-list ref] wrote:
quoted hunk
From: Krzysztof Helt <redacted> Does not allow to accept VESA modes by the "vga=" kernel parameter if there is no frame buffer driver compiled-in to handle it. Bug was reported by Werner Lemberg as kernel bug #13249 "Intel 945GM: Boot option`vga=0x31a' breaks display of TTYs". Signed-off-by: Krzysztof Helt <redacted> --- Werner, please test it. It should produce a correct display with intelfb compiled in (=y) and as a module (=m).diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig index 0048f11..c787357 100644 --- a/drivers/video/Kconfig +++ b/drivers/video/Kconfig@@ -1122,7 +1122,7 @@ config FB_INTEL select FB_CFB_FILLRECT select FB_CFB_COPYAREA select FB_CFB_IMAGEBLIT - select FB_BOOT_VESA_SUPPORT + select FB_BOOT_VESA_SUPPORT if FB_INTEL = y help This driver supports the on-board graphics built in to the Intel 830M/845G/852GM/855GM/865G/915G/915GM/945G/945GM/965G/965GM chipsets.@@ -1460,7 +1460,7 @@ config FB_SIS select FB_CFB_FILLRECT select FB_CFB_COPYAREA select FB_CFB_IMAGEBLIT - select FB_BOOT_VESA_SUPPORT + select FB_BOOT_VESA_SUPPORT if FB_SIS = y help This is the frame buffer device driver for the SiS 300, 315, 330 and 340 series as well as XGI V3XT, V5, V8, Z7 graphics chipsets.
I read through http://bugzilla.kernel.org/show_bug.cgi?id=13249 and am now unsure what to do with this patch? ------------------------------------------------------------------------------ Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT is a gathering of tech-side developers & brand creativity professionals. Meet the minds behind Google Creative Lab, Visual Complexity, Processing, & iPhoneDevCamp as they present alongside digital heavyweights like Barbarian Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com