On Tue, May 19, 2009 at 10:07:48AM +0200, Krzysztof Helt wrote:

I believe it is correct. I have no chance to test. 
Acked-by: Krzysztof Helt <redacted>

Thanks for your review.  Right now, nobody but VIA and OLPC has hardware to test,
as far as I know.  This is why I'm pushing for this code to get included now,
i.e. the kernel works on the hardware once it ships in quantity.

 

quoted

+/* For VT3409 */
+#define VX855_IGA1_FIFO_MAX_DEPTH               400
+#define VX855_IGA1_FIFO_THRESHOLD               320
+#define VX855_IGA1_FIFO_HIGH_THRESHOLD          320

Are these two values above always the same? If so you can use
a single symbol. 

Well, as you can see, they are not the same on other chips than the VX855,
so I left the two separate #defines to be orthogonal.  I hope I find enough
time to clean this up and have all those values in a structure, indexed by
the chip variant at some point.

-- 
- Harald Welte [off-list ref]	    http://linux.via.com.tw/
============================================================================
VIA Open Source Liaison

------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables 
unlimited royalty-free distribution of the report engine 
for externally facing server and web deployment. 
http://p.sf.net/sfu/businessobjects