Thread (7 messages) 7 messages, 3 authors, 2009-05-16

Re: [PATCH 6/8] ARM: OMAP2/3: Change omapfb to use clkdev for dispc and rfbi

From: Tony Lindgren <tony@atomide.com>
Date: 2009-05-16 15:25:43
Also in: linux-omap

* Russell King - ARM Linux [off-list ref] [090516 02:06]:
On Thu, May 14, 2009 at 01:28:06PM -0700, Tony Lindgren wrote:
quoted
commit 27db33cfadd3c47c9499def6e71aaf5d2fd51e60
Author: Tony Lindgren [off-list ref]
Date:   Tue May 12 11:20:03 2009 -0700

    ARM: OMAP2/3: Change omapfb to use clkdev for dispc and rfbi, v2
    
    This makes the framebuffer work on omap3.
    
    Also fix the clk_get usage for checkpatch.pl
    "ERROR: do not use assignment in if condition".
    
    Cc: Imre Deak [off-list ref]
    Cc: linux-fbdev-devel@lists.sourceforge.net
    Acked-by: Krzysztof Helt [off-list ref]
    Signed-off-by: Tony Lindgren [off-list ref]
This isn't a bug fix - the current code works, although checkpatch will
complain about the assignment in the if condition.

The rest of the patch is just a conversion from the old way of doing
things to the new way, and I don't think is -rc material.
The code does not work for omap3 without this patch because of the
different clock names. It only works for 24xx. And because of the
different source clocks, it's pointless trying to fix it in any
other way for -rc series.

Dropping anyways from the omap-fixes series, we can wait a bit
longer.

Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help