Re: [PATCH] platinumfb: misplaced parenthesis
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2009-05-15 22:21:45
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2009-05-15 22:21:45
On Sat, 2009-05-16 at 00:24 +0300, Ville Syrjälä wrote:
How about just pulling that magic video_mode/cmode handling out of that single statement so that it could be parsed with less effort?
Agreed. Just store the base value in a variable, then do an if (VMODE/CMODE) that adds the offset or something like that. Cheers, Ben. ------------------------------------------------------------------------------ Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment. http://p.sf.net/sfu/businessobjects _______________________________________________ Linux-fbdev-devel mailing list Linux-fbdev-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel